-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback on 3.0.0 #16
Comments
I am seeing some weird behaviour on a list with inline italics. The italics line always gets placed in a separate line. Seeing this in multiple places. Sample .md
Here for github rendering
|
After doing some more testing, I grabbed a couple of screenshots of the same .md put through markopolis and obsidian-webpage export just to compare. If anything, the only suggestion I would have is to add back the outline/table of contents (ideally make it optional), as for longer pages/content it will help with navigation. Thanks! |
Thank you so much for your feedback. Really appreciate them. I can fix the issues you raised. As of now you are right in that the date shown is the date uploaded and currently there's no way to override it. Tbh the date in the frontmatter is not considered at all even though it's available and stored. So that's an easy fix. I can revert to the home page too and the titles in the fileTree. The real reason I removed ToC was I didn't know where to lay it on the screen. It looked ugly dangling on it's own. I guess I can make it available as a togglable pane like the tag explorer. Feel free to let me know if you have any other suggestions for the ToC UI. |
Yes, I think a togglable pane is the best option. All you need is a button, and in terms of appearance what you had in 0.x.x was absolutely fine. Just a simple outline with all the (clickable) headings.
I think you have a solid base to work from now. Take your time and look at what your roadmap. ie,
etc. That might make it a bit easier to handle further down the line.Also, please find below some additional issues that I spotted in the meantime.
Folder structure if you want to try and replicate.
my
The title is being rendered as
|
Lol I completely missed the Regarding the title: property I'm not sure I'm understanding this correctly. so you have a note within the blog folder called For the upload yes, if you don't add a Once again thanks a tonne mate for the feedback !! Your interest in this project and your thorough feedback on the various aspects of it makes me so happy and is a big encouragement to contribute more to it. Appreciate it a lot :) |
Based on what you said below, this should be failing to upload as the note doesn't even have a title. Not a big deal, but it leads me to believe it's messing with the upload logic?
Think that's a sensible approach.
You're welcome! |
Just pushed 3.0.1 which fixes these. The markopolis cli python package has also been updated to 3.0.1 which now respects publish. Now the default behavior is to publish all markdown. You override by setting publish: false to exclude files from being published. You can override dates with values in your frontmatter and dates are now optional. Not including one in the frontmatter will simply not show a date on the page. docker images are being pushed as I type :) Let me know if you face any issues. |
Currently away for a couple of weeks but once I get the chance I will test and provide feedback. Thanks for the update! |
Ok finally had the time to test 3.0.1 today.
date: is working but formatting looks a bit weird to me. Thanks for the update, these minor fixes really enhance the usability for this. |
That's just the default format in which timestamps are stored. I can change that to show only the date. |
I've seen that, and I'm currently trying it out! That's some clear progress, I think you've closed out the majority of the open items. To sum it up, I'm currently only seeing the 2 following issues:
Otherwise, in functional terms, pretty much everything I've checked seems to be working. I'll report back with any other findings. |
Following up from the above, there's a few more quirks on the wikilink aliasing. If I have a test.md with title: "this is a test", but create a link as Not sure if you want to implement some logic to allow the link to be rendered based on the title. However, if you implement aliasing (ie, [[foo|bar]] is expected to link to foo.md and display bar) then it's easy to workaround this. |
Separate note, you might want to reimplement the "latest" tag for the docker images. At the moment people will have to specify the image version, meaning the sample docker compose wouldn't work, for example. |
Good point. I'll do that. At this point I'll probably set up a GitHub actions. |
Hi rishikanthc, I have a couple more random suggestions. In the example docker compose, I think the 8080 port should be removed, or at least marked optional. As far as I can see it's only needed if someone wants to access the pocketbase ui directly. I don't think there's any reason for most users to use it. It's not required to be exposed to allow the container to works. Exposing it only decreases security in case someone doesn't change the sample passwords. Secondly, whenever I restart the container (which I did a few times as I was trying a few things on my VPS), Markopolis always seems to go through the rebuild process again. This was killing my low powered vps until I put in some resource limits in the docker compose. I am just wondering if whatever is being "built" is being stored in temporary storage? Is there a way to optimise this so it is stored in a volume so as not to get erased with every restart, just to avoid this? |
Point well taken. I'll remove that. |
Just wanted to provide some feedback on the usability and look of the pages for 3.0.0.
Overall, this looks really good.
I do have a few points/suggestions:
The default page now seems to be an auto generated "Latest" rather than the previous
home.md
. Would like to be able to set a default page instead, as per previous behaviour. If not "home.me" then "index.md".The navigation bar/file tree shows the filenames with extension. In my opinion you should overwrite this with the note's
title:
propertyThe date being shown under each note is nice (as is the tag), but I assume it's being derived from the upload date?
I haven't tried yet, but can it be overridden by a
date:
property? And can it be hidden/blank by setting the property to something specific?I'd like to publish some notes where it absolutely makes sense to have a date, but for a "Home" or "About me" kind of section, it would look better not to have any date.
The text was updated successfully, but these errors were encountered: