Move register layout definitions into wavedrom #414
Assignees
Labels
v1.0
resolve for 1.0
Comments
|
Can you point me at a CSR diagram from the Privileged spec that you would expect the CSRs here to look like? |
|
Maybe mnstatus from the rnmi chapter 8.3? |
|
I think we are open to whatever is the preferred presentation by the documentation team. I was looking at the privileged spec itself, i.e. definition of machine mode. |
|
Can you let me know if the content of this diagram is correct? I've left the textual description above the diagram for reference: |
looks fine |
|
looks ok from my side |
wmat
added a commit
that referenced
this issue
Nov 11, 2024
Before issuing PR this adds issue #414 to move register layout definitions to be diagrams.
jb-brelot-nxp
pushed a commit
that referenced
this issue
Jan 6, 2025
* Move clicintaddr register to wavedrom Move clicintaddr register to wavedrom diagram * Add register diagram for clicinittrig Add the register diagram for clickinittrig as a bytefield-svg diagram to accomodate long names. * Adding xtvec register. Adds the xtvec register diagram using bytefield-svg to accommodate long register names. * Add clicintattr register layout diagram. Adds the clicintattr register diagram. This uses wavedrom as the register names are short. * Fix clicintattr diagrams Fix the clicintattr diagrams. * Add mcliccfg and scliccfg register diagrams Add the mcliccfg and scliccfg register diagrams as bytefield-svg to accomodate long register names. * Delete text based register description. Delete several of the text based descriptions of register diagrams. * Add issue #414 to revision history Before issuing PR this adds issue #414 to move register layout definitions to be diagrams. * Grabbing latest docs-resources so PDF builds on PR. Grabbing the latest docs-resources so the PDF builds for the PR. --------- Signed-off-by: Bill Traynor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The privileged spec defines the CSR layouts using wavedrom. The CLIC spec doesn't. This should be aligned.
The layout diagrams do not include descriptions, while the CLIC tables do.
Proposed Resolution:
Move CLIC CSR layouts to wavedrom. Merge the description text with from the layout table with the rest. There might be redundancies, in which the text that doesn't come from the table should take presedence.
The text was updated successfully, but these errors were encountered: