Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: suppress PRNG seed ... log messages when gdbserver.py --list-tests <target> used #561

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

TommyMurphyTM1234
Copy link
Contributor

@TommyMurphyTM1234 TommyMurphyTM1234 commented Jun 6, 2024

gdbserver.py --list-tests <target> should output a list of tests for the selected target and nothing else.
An earlier PR/commit caused two PRNG seed ... log mesages to always be output at startup even when --list-tests was used.
This, in turn, caused problems with the Makefile driven tests.
This PR simply suppresses these PRNG seed ... log messages when --list-tests has been specified.

See here for more background:

debug/gdbserver.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TommyMurphyTM1234 TommyMurphyTM1234 changed the title Suppress 'PRNG seed ...' log messages when --list-tests is specified Debug: suppress PRNG seed ... log messages when gdbserver.py --list-tests <target> used Jun 10, 2024
@TommyMurphyTM1234
Copy link
Contributor Author

Can this be merged now?

@aap-sc
Copy link
Collaborator

aap-sc commented Jun 27, 2024

Can this be merged now?

Sorry! Completely forgot about this one.

@aap-sc aap-sc merged commit 74c9c14 into riscv-software-src:master Jun 27, 2024
2 checks passed
@TommyMurphyTM1234
Copy link
Contributor Author

Can this be merged now?

Sorry! Completely forgot about this one.

Thanks a lot @aap-sc. 👍

@TommyMurphyTM1234 TommyMurphyTM1234 deleted the fix-list-tests branch June 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants