Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Motherless ripper #194

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fixed Motherless ripper #194

merged 2 commits into from
Jul 17, 2024

Conversation

brantspar
Copy link

@brantspar brantspar commented Jun 28, 2024

The Motherless ripper was broken as the rip operation was not waiting on all the threads created to download the files from motherless.

This repo reminded me as to why OO inheritance is just plain bad... too hard to follow what's happening!

Also

  • increased default http retries to 3 (why only 1?)
  • fixed deprecation message for Motherless ripper

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

- increased default retries to 3 (why only 1?)
- fixed deprecation message for Motherless ripper
@brantspar
Copy link
Author

@soloturn for visibility

@brantspar
Copy link
Author

brantspar commented Jul 9, 2024

I have fixed the tests however the build ends with this error

Could not create new tag "refs/tags/latest-194-merge" (Resource not accessible by integration) therefore updating existing tag "tags/latest-194-merge"
  Error: Resource not accessible by integration

It looks like it's related to this -> marvinpinto/actions#61 -> The pull requests run with read-only permissions because they are made by other users

@soloturn soloturn merged commit e938ac9 into ripmeapp2:main Jul 17, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants