Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LusciousRipper non existing method test removed #160

Merged
merged 5 commits into from
Dec 1, 2023
Merged

LusciousRipper non existing method test removed #160

merged 5 commits into from
Dec 1, 2023

Conversation

joroto
Copy link

@joroto joroto commented Nov 26, 2023

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Second PR for #154 as the last one (#156) blocked the release build

@joroto joroto mentioned this pull request Nov 26, 2023
5 tasks
@joroto joroto changed the title LusciousRipper fixed LusciousRipper non existing method test removed Nov 26, 2023
@soloturn soloturn merged commit 63760ea into ripmeapp2:main Dec 1, 2023
1 of 4 checks passed
@soloturn
Copy link

soloturn commented Dec 1, 2023

merged. you are aware that this was only the test class, as the title says. not fixing a ripper as the text here says? for the backed out pull request, you could create a new branch and cherry pick the commit. depends on the editor you use, for intellij it is like this: https://www.youtube.com/watch?v=plZT7PQtijg, for vscode like this: https://www.youtube.com/watch?v=wIY824wWpu4.

@joroto
Copy link
Author

joroto commented Dec 1, 2023

I did not understand what you mean. The previous PR #156 is merged right? I saw you reverted it and then reverted the revert. So the only changes needed were to the test as it was trying to call a method that does not exist, which this PR fixes. Is there anything else I need to do?

@soloturn
Copy link

soloturn commented Dec 1, 2023

ah, no, all good, i guess. it built red for other tests. of course, if you ask, it would be cool if you fix such tests as well or mark them flaky :) facilitates release ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lu.scio.us not working
2 participants