Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LusciousRipper fixed #156

Merged
merged 1 commit into from
Nov 18, 2023
Merged

LusciousRipper fixed #156

merged 1 commit into from
Nov 18, 2023

Conversation

joroto
Copy link

@joroto joroto commented Nov 4, 2023

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

LusciousRipper fixed

Testing

Multiple galleries downloaded successfully.

@soloturn soloturn merged commit ce0e60c into ripmeapp2:main Nov 18, 2023
@soloturn
Copy link

it blocks the release build @joroto :
https://github.com/ripmeapp2/ripme/actions/runs/6912321974/job/18807933637

> Task :compileTestJava FAILED
/home/runner/work/ripme/ripme/src/test/java/com/rarchives/ripme/tst/ripper/rippers/LusciousRipperTest.java:35: error: getFirstPage() has protected access in AbstractHTMLRipper
        assert (multiPageRipper.getNextPage(multiPageRipper.getFirstPage()) != null);
                                                           ^
/home/runner/work/ripme/ripme/src/test/java/com/rarchives/ripme/tst/ripper/rippers/LusciousRipperTest.java:40: error: getFirstPage() has protected access in AbstractHTMLRipper
            singlePageRipper.getNextPage(singlePageRipper.getFirstPage());

@joroto
Copy link
Author

joroto commented Nov 26, 2023

@soloturn Yes, my bad. Should be fixed with #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lu.scio.us not working
2 participants