Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use memento API to persist remembered keys #91

Open
dvirtz opened this issue Aug 15, 2024 · 3 comments
Open

use memento API to persist remembered keys #91

dvirtz opened this issue Aug 15, 2024 · 3 comments

Comments

@dvirtz
Copy link

dvirtz commented Aug 15, 2024

VSCode has a dedicated API to persist data: https://code.visualstudio.com/api/references/vscode-api#Memento
Using that would solve the caveats with persistent.file described in https://marketplace.visualstudio.com/items?itemName=rioj7.command-variable#settings such as working with a remote workspace

@rioj7
Copy link
Owner

rioj7 commented Aug 15, 2024

@dvirtz the update method is async and I don't think I can call async stuff in the deactivate method of the extension. VSC has signaled that it is about to remove the extension.

@dvirtz
Copy link
Author

dvirtz commented Aug 15, 2024

I think you can call it on every change instead. Maybe only save it there even.

@dvirtz
Copy link
Author

dvirtz commented Aug 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants