Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: code doesn't check "I" arguments #169

Open
kendonB opened this issue Apr 18, 2017 · 1 comment
Open

check: code doesn't check "I" arguments #169

kendonB opened this issue Apr 18, 2017 · 1 comment
Labels

Comments

@kendonB
Copy link

kendonB commented Apr 18, 2017

R:

test_function <- function(x){
  Sys.sleep(2)
  x
}

remake.yml:

sources: test_function.R
targets:
  all:
    depends:
    - test
  test:
    depends: remake.yml
    command: test_function(I(3))
    check: code
make()
#> [  LOAD ] 
#> [  READ ]       |  # loading sources
#> <  MAKE > all
#> [ BUILD ] test  |  test <- test_function(3)
#> [  READ ]       |  # loading packages
#> [ ----- ] all

New remake.yml:

sources: test_function.R
targets:
  all:
    depends:
    - test
  test:
    depends: remake.yml
    command: test_function(I(2))
    check: code
make()
#> [  LOAD ] 
#> [  READ ]       |  # loading sources
#> <  MAKE > all
#> [    OK ] test
#> [ ----- ] all

check: all seems to work.

@krlmlr
Copy link
Collaborator

krlmlr commented Aug 26, 2017

Thanks, this seems wrong indeed.

@krlmlr krlmlr added the bug label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants