Calculate the average #2
Conversation
| @@ -98,6 +102,9 @@ function RoomCtrl($scope, $routeParams, $timeout, socket) { | |||
| $scope.placeholderVotes = voteArr; | |||
|
|
|||
|
|
|||
| var total = _.reduce(_.map(_.pluck($scope.votes, 'vote'), parseFloat), sumOfTwo, 0); | |||
There was a problem hiding this comment.
There's a bug here. parseFloat will choke if anyone has voted ½ or with a non-numeric vote. Non-numeric votes should be excluded and ½ translated to 0.5.
There was a problem hiding this comment.
This PR was open almost 7 years before it go a review (and another 1.5 years before I noticed). I'm not mad -- that's amazing!
There was a problem hiding this comment.
Amazing but accidental. From my side, it was meant as a bug report through a non-standard channel than a code review. I must have encountered the bug in the wild before I even started looking for the root cause.
There was a problem hiding this comment.
Sorry, that came across like a complaint and a I didn't mean for it to be. I just thought it was amusing -- pretty cool actually -- that you saw the PR and responded to it after such a long time. And that it took me such a long time to see that you had responded.
Open source is hard.
There was a problem hiding this comment.
Hard, and honestly amazing (often amusing, too). No irony read or intended.
|
Average and StdDev calculations are already in master, I believe this PR can be closed. |
Fixes #1. Shows the average after you're finished voting.