Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 - Customize line numbers starting number #615

Closed
alexandercerutti opened this issue Jan 3, 2024 · 5 comments · Fixed by #624
Closed

🚀 - Customize line numbers starting number #615

alexandercerutti opened this issue Jan 3, 2024 · 5 comments · Fixed by #624
Labels
feature New feature or request next Issues or pull request to do in next branch (until 6th May) P2 This issue has medium priority
Milestone
January update

Comments

@alexandercerutti
Copy link
Contributor

Which @codeimage/* package(s) are relevant/releated to the feature request?

Don't known / other

Description

It would be nice to let line numbers to start from a specific arbitrary positive number.

Thank you!
@alexandercerutti alexandercerutti added the feature New feature or request label Jan 3, 2024
@github-project-automation github-project-automation bot moved this to Todo in CodeImage Jan 3, 2024
@riccardoperra riccardoperra added this to the January update milestone Jan 3, 2024
@riccardoperra
Copy link
Owner

initial implementation: #613

@riccardoperra riccardoperra added the P2 This issue has medium priority label Jan 5, 2024
@riccardoperra riccardoperra mentioned this issue Jan 7, 2024
Merged
@riccardoperra riccardoperra linked a pull request Jan 7, 2024 that will close this issue
feat(app,api): add line number start option #624
Merged
@riccardoperra riccardoperra moved this from Todo to To Merge in CodeImage Jan 7, 2024
@riccardoperra riccardoperra added the next Issues or pull request to do in next branch (until 6th May) label Jan 7, 2024
@riccardoperra
Copy link
Owner

riccardoperra commented Jan 7, 2024 •
edited
Loading

Implementation ready in this pr #624.
Will be deployed in next update. Changes will reflect also backend api so full pipeline must be run

@stale stale bot added the wontfix This will not be worked on label Mar 8, 2024
@stale stale bot closed this as completed Mar 16, 2024
@github-project-automation github-project-automation bot moved this from To Merge to Done in CodeImage Mar 16, 2024
@riccardoperra riccardoperra removed the wontfix This will not be worked on label Mar 16, 2024
@riccardoperra riccardoperra reopened this Apr 20, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in CodeImage Apr 20, 2024
Repository owner deleted a comment from stale bot Apr 20, 2024
@riccardoperra
Copy link
Owner

riccardoperra commented Apr 20, 2024 •
edited
Loading

Finally had the time to merge the implementation 😄 Will be available soon in prod

@riccardoperra riccardoperra moved this from In Progress to To Merge in CodeImage Apr 20, 2024
@riccardoperra riccardoperra moved this from To Merge to Done in CodeImage Apr 20, 2024
@riccardoperra
Copy link
Owner

riccardoperra commented Apr 27, 2024 •
edited
Loading

Released with 1.6.0. Thanks 😄

@riccardoperra
Copy link
Owner

P.S. Alla fine ti ho nominato anche nel changelog dentro l'app 😬 Prima o poi rilascero anche il resto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request next Issues or pull request to do in next branch (until 6th May) P2 This issue has medium priority
Projects
CodeImage
Status: Done
Milestone
January update
Development

Successfully merging a pull request may close this issue.

feat(app,api): add line number start option riccardoperra/codeimage
2 participants
@alexandercerutti @riccardoperra