-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown fenced code excessive useless errors #48
Comments
@blakeembrey and @despairblue What are your thoughts on this issue? |
@ricardofbarros I don't have too much of an issue with excessive errors in my markdown since I try to make it runnable most of the time. Maybe if it's a config option on the module for the people who do have an issue though. Aside from that, yeah, I'm happy with a comment when needed. |
Okay, it seems plausible having a sub option to ignore those pesty warnings. |
Maybe just have a text option to enter whatever eslint options? |
@ricardofbarros The only error that I'm getting and doesn't make sense is the "newline required at end of file". |
Yeah, it doesn't make any sense at all. To ignore your error you need to have your code formatted like this: /```js /``` That's why I feel strongly about having a small list of rules disabled (as of now 3) when we are linting fenced code blocks. |
It would probably be best to disable the same rules standard-markdown disables. |
So now if you lint the markdown files you will have the following errors pop up most of the time:
no-unused-vars
no-undef
I already had pointed out this could happen and it would be annoying.
My solution is to under the hood wrap the fenced code block in the following manner:
The text was updated successfully, but these errors were encountered: