Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRI detrended #26

Open
adesider73 opened this issue Apr 3, 2021 · 3 comments
Open

RRI detrended #26

adesider73 opened this issue Apr 3, 2021 · 3 comments
Labels

Comments

@adesider73
Copy link

When calculating rri_detrended with the smoothness priors method: rri_detrended = smoothness_priors(rri, l=500, fs=4.0) the rri_detrended values have a spike towards the end (see 2nd graph below) for both sample files real_rri.txt and rest_rri.txt which looks off. Is this expected behaviour or a bug? Thanks for your feedback.
Screen Shot 2021-04-03 at 15 44 08

@rhenanbartels
Copy link
Owner

Hi @adesider73, how are you doing?

Thanks for your feedback. This is an expected bug :/

This happens, because in some cases the NumPy can not represent the tiny values present in the calculation of smoothness priors and round them off.
I will check if it is possible to overcome this limitation using Numpy's float128.

@adesider73
Copy link
Author

Hi Rhenan, I'm doing good - how are you? Many thanks for your prompt reply and the explanation - much appreciated!

@noah10
Copy link

noah10 commented Jun 2, 2021

I've recently encountered this bug as well. Unfortunately it has made smoothness priors unusable for me and I've had to switch to Savitzsky-Golay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants