forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Pokémon Jump types to gSpeciesInfo #5602
Open
AsparagusEduardo
wants to merge
3
commits into
rh-hideout:upcoming
Choose a base branch
from
AsparagusEduardo:_RHH/pr/upcoming/pokemonJump
base: upcoming
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Moved Pokémon Jump types to gSpeciesInfo #5602
AsparagusEduardo
wants to merge
3
commits into
rh-hideout:upcoming
from
AsparagusEduardo:_RHH/pr/upcoming/pokemonJump
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the PLA mons and forms needed pokemon jump data as well. |
True, true. Will do in a sec |
AsparagusEduardo
force-pushed
the
_RHH/pr/upcoming/pokemonJump
branch
from
October 29, 2024 15:29
661cbc4
to
c4b393e
Compare
Rebased to upcoming with only the relevant changes.
And gave Totem Togedemaru Normal Jump. |
Any chance we could get a migration script for this? |
20 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the last things left to move to
gSpeciesInfo
.Also, added the following missing data to PLA/Gen 9 Pokémon that are smaller than 71 cm:
PKMN_JUMP_TYPE_NONE
:PKMN_JUMP_TYPE_FAST
PKMN_JUMP_TYPE_NORMAL
PKMN_JUMP_TYPE_SLOW
Discord contact info
AsparagusEduardo