Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider publishing it as 2 separate packages #123

Open
danielhusar opened this issue Jan 21, 2019 · 1 comment
Open

Consider publishing it as 2 separate packages #123

danielhusar opened this issue Jan 21, 2019 · 1 comment

Comments

@danielhusar
Copy link

First, thanks for this great library.

Would you consider publishing it as 2 separate packages? (Parse and Stringify)
We are using only Parse method, but right now it will still bundle the whole library.

Changing import { parse } from 'css'; to import parse from 'css/lib/parse'; reduces pre GZIP size by more than 90%;

CSS module size in bundle before:
screen shot 2019-01-18 at 12 51 59

CSS module size in bundle after:
screen shot 2019-01-18 at 12 50 16

But we are risking that if internal api changes, it will break for us.

@holblin
Copy link

holblin commented May 26, 2022

This is probably due to source-map support (and the associated dependencies). Removing it might be enough.

I worked on removing the source-map support. This will solve the issue. Trying to reach out to the rework members before going into the fork route (and discussing with my company for the PR route).
ref: #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants