Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags not properly passed in entrypoint #142

Open
JennyFigueroaMSR opened this issue Sep 26, 2024 · 1 comment
Open

Flags not properly passed in entrypoint #142

JennyFigueroaMSR opened this issue Sep 26, 2024 · 1 comment

Comments

@JennyFigueroaMSR
Copy link

JennyFigueroaMSR commented Sep 26, 2024

The reviewdog flags (and possibly the actionlint flags) are not being properly passed to their commands. The ${INPUT_XXX_FLAGS} need to be wrapped in quotes.

For example, this does not work:

  lint:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v4

      - name: Call Actionlint
        id: action
        uses: reviewdog/[email protected]
        with:
          reporter: local
          reviewdog_flags: -diff="git diff main"

It fails with:

reviewdog: invalid command line string

I tested this by using act in offline mode to run a modified image of the Dockerfile. It happened to get stuck when running it, so I shelled into the container. When shelled into the container:

  • I ran the entrypoint with sh /entrypoint.sh and verified that the error still occurs
  • I added quotes around ${INPUT_REVIEWDOG_FLAGS} in the entrypoint
  • I ran the entrypoint again and saw the results I was expecting

I suspect that this may have something to do with #80 as well.

edit: Looks like adding quotes doesn't fix it as I thought it would. Needs some more tinkering for a real solution

@hugo-syn
Copy link

Same issue, did you manage to find a fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants