Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes not working anymore on RetroGo 1.40 #2

Open
explit7 opened this issue Feb 28, 2024 · 4 comments
Open

Themes not working anymore on RetroGo 1.40 #2

explit7 opened this issue Feb 28, 2024 · 4 comments

Comments

@explit7
Copy link

explit7 commented Feb 28, 2024

In the past it was necessary just to copy the themes to the Retro-Go Themes folder and it worked.
Now, the structure is changed and each theme need an theme.json file
See here: https://github.com/ducalex/retro-go/blob/master/THEMING.md

Could you please update the themes with the needed theme.json files ?

Thanks

@dat-atr-ash
Copy link

@explit7, you can just put the example JSON from https://github.com/ducalex/retro-go/blob/master/THEMING.md in the folder(s).
Might want to adjust some colors though.

I might or might not open a PR for the missing bg and logos for the pixel theme..

@explit7
Copy link
Author

explit7 commented Oct 3, 2024

@explit7, you can just put the example JSON from https://github.com/ducalex/retro-go/blob/master/THEMING.md in the folder(s). Might want to adjust some colors though.

I might or might not open a PR for the missing bg and logos for the pixel theme..

Thanks for your reply, but could you point me, where the example.json is? I cant find it in the repo.
Maybe you can share your json?

[email protected]

Thank you very much.

@defy-all
Copy link

defy-all commented Oct 3, 2024

@explit7, there is no file example.json in the retro-go repo.

But there is some json on THEMING.md that can just be pastet into an empty file in the theme folder(s).

However, it is even simpler than that:
All fields in theme.json are optional.
Just create a file called theme.json and put an opening and a closing curly bracket in there.
Put that file in each of your theme directories.
Done.

You'll have the default color options that you already know.

@explit7
Copy link
Author

explit7 commented Nov 19, 2024

This is my minimal theme.json
Maybe it could be better. But it works for me

{
    "description": "Theme description",
    "website": "https://example.com/retro-go-theme",
    "author": "John Smith",
    "dialog": {
        "__comment": "This section contains global dialog colors",
        "foreground": "0xFFFF",
        "background": "0x0010",
        "border": "0x6B4D",
        "header": "0xFFFF",
        "scrollbar": "0xFFFF",
        "item_standard": "0xFFFF",
        "item_disabled": "0x8410",
        "item_message": "0xBDF7"
    }
}

@explit7 explit7 mentioned this issue Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants