Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citaiton Key column disappears #2136

Closed
lrperlmu opened this issue Apr 29, 2022 · 16 comments
Closed

Citaiton Key column disappears #2136

lrperlmu opened this issue Apr 29, 2022 · 16 comments
Labels

Comments

@lrperlmu
Copy link

lrperlmu commented Apr 29, 2022

Summary

On MacOS, Citation Key column disappears under certain conditions and I need to relaunch zotero to make it reappear.

System and version information

MacOS 10.14.6
Zotero 6.0.6

Reproduction Steps

  1. Launch Zotero
    • Upon launching, the citation key column appears between "title" and "creator"
    • I can toggle this column on and off by right clicking the name of a column and selecting or deselecting "Citation Key" in the context menu
  2. Click the red X in the upper left hand corner of the zotero window to close the window without terminating the application
  3. Click the Zotero dock icon to open a zotero window
    • Upon opening a new window, the citation key column does not appear
    • (This is the step where I generated a support log. Support log ID below.)
    • When I right click the name of a column, "Citation Key" does not appear in the context menu as a column that can be added to the view
  4. Right click the Zotero dock icon and select "Quit". This closes the Zotero window and terminates the application.
  5. Launch Zotero
    • "Citation Key" column is back in business

Support Log ID:

AE2ERRYJ-refs-euc

@lrperlmu
Copy link
Author

possibly related to #2088, though I'm not sure if it's exactly the same issue.

@retorquere
Copy link
Owner

Oh that could very well be related.

This problem unfortunately requires a substantial re-structuring of BBT. It's work I'm planning for the coming months but I can't give an ETA; until I have that restructuring done the cure is, unfortunately, "don't do that". BBT starts up when the main window displays, and on MacOS, that can happen more than once if you red-cross and re-open Zotero. The startup process of BBT isn't robust against that.

@qqobb
Copy link
Contributor

qqobb commented Apr 30, 2022

Click the red X in the upper left hand corner of the zotero window to close the window without terminating the application

I don't know anything about the issue, but it sounds like this could be related to jlegewie/zotfile#595.

@qqobb
Copy link
Contributor

qqobb commented Apr 30, 2022

There's also zotero/zotero#1952.

@retorquere
Copy link
Owner

Yeah, it's related to that. I employ the same mitigation strategy, but it does not cover all cases.

@retorquere
Copy link
Owner

I'm going to change BBT to restartless start. This was necessary anyhow, and it'll likely solve this problem and a few other open issues, but it'll take (quite) a bit of time to get it done.

@dstillman
Copy link

Following up on https://groups.google.com/g/zotero-dev/c/jYbUlGEMJTc/m/Dj6Zr8lzAgAJ, there may not be a great solution to this at the moment, and XBL bindings are going away in the Fx102 branch anyway.

What if we just add Citation Key to all item types? What effect will that have on you? The Citation Key field in Preprint is just a regular field, but is there bare-minimum special functionality that a Citation Key field would need, from your perspective?

@lrperlmu
Copy link
Author

Thanks for asking! To clarify, are you proposing that all zotero items could have a citation key field, even without using the BBT extension? Would launching BBT then make each item have 2 citation key fields that could potentially have different values? That would be kind of confusing especially when it comes to which one is used when exporting.

Citation key end user features that are important to me include:

  1. Auto generate a citation key for each newly added item using my JabRef-ish pattern specified in settings.
  2. Use this citation key when exporting to .bib file

@dstillman
Copy link

dstillman commented Jun 11, 2022

Sorry, my question was for @retorquere. Zotero was always going to get a Citation Key field for all items — I'm just trying to coordinate with @retorquere to avoid problems for BBT users when we add it.

@retorquere
Copy link
Owner

retorquere commented Jun 11, 2022

What if we just add Citation Key to all item types? What effect will that have on you? The Citation Key field in Preprint is just a regular field, but is there bare-minimum special functionality that a Citation Key field would need, from your perspective?

The main issue will be if/when to generate these keys. A lot of functionality in BBT assumes regular items always have a citekey. With the citekey in a normal (editable) item field, key behavior becomes equivalent to all items having pinned keys, and that means functionality changes for BBT users.

It seems to me the most understandable behavior would be to (only) generate keys when the field is empty. This does mean BBT would lose the dynamic keys and delayed-pinned keys, but mimicking these two behaviors with an item field would mean there would need to be something like a separate checkbox to indicate that the key is fixed, and that does not feel like a good UI concept to me.

With key behavior being like pinned keys it'd mean that if the keys are to follow the content of the item, it'd be a manual action by the user to adjust the keys to the item content; maybe a refresh button could be added next to the citekey field, and a right-click action on the item list to refresh keys.

I'd propose that either Zotero's key-generating function be monkey-patchable so that I can replace it with the BBT key generator, or alternatively that Zotero just does not generate keys and leaves that to BBT. In the latter case, it'd be nice if it weren't too difficult for me to add the refresh button next to the citekey in the item pane. Other than that, no special functionality I can think of.

@DesBw
Copy link

DesBw commented Feb 9, 2023

It might be useful to adopt the idea of Core Plugin and Community Plugins from Obsidian.

  • Ship Better bibtex as a core plugin with every release of Zotero
  • Make Zotero generate no cite key of its own: leave the task for Better Bibtex.

@retorquere
Copy link
Owner

In that scenario, why have a core plugin rather than just build it into Zotero? If not built in, what would it mean to be a core plug in? Just that I'm held to their release schedule?

Once zotero adds its own citation key field, BBT will still generate its contents while installed.

@DesBw
Copy link

DesBw commented Feb 9, 2023

I think generally, Zotero needs some means of organizing its plugins. They are cluttered everywhere and many users struggled to find them.

  • The idea of Core plugin is: just regular plugin; but shipped with the main application. Every modification and release is still made by the plugin developer (I guess). Community plugins are not shipped with the main application. The user has to manually install them.

Once zotero adds its own citation key field, BBT will still generate its contents while installed.

This is also good so far as it works for you.

@retorquere
Copy link
Owner

They can ship BBT with Zotero, you'd have to ask them.

@retorquere
Copy link
Owner

But this doesn't have to do with the issue under discussion here.

@retorquere
Copy link
Owner

The original issue has been solved a few versions back.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants