Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove header env var parsing from tracing_instrumentation #1217

Closed
jackkleeman opened this issue Feb 26, 2024 · 0 comments · Fixed by #1406
Closed

Remove header env var parsing from tracing_instrumentation #1217

jackkleeman opened this issue Feb 26, 2024 · 0 comments · Fixed by #1406
Assignees
@jackkleeman

Comments

@jackkleeman
Copy link
Contributor

jackkleeman commented Feb 26, 2024 •
edited
Loading

restate/crates/tracing-instrumentation/src/lib.rs

Line 173 in 372c223

// Until https://github.com/open-telemetry/opentelemetry-rust/pull/1377 is released, we copy its logic

This can be removed when open-telemetry/opentelemetry-rust#1377 is released
@jackkleeman jackkleeman self-assigned this Feb 26, 2024
jackkleeman added a commit to jackkleeman/restate that referenced this issue Apr 16, 2024
@jackkleeman
Update opentelemetry libraries
fe40aac 
otel has been released with the changes we needed, we can now avoid parsing header env var manually.

Fixes restatedev#1217
@jackkleeman jackkleeman mentioned this issue Apr 16, 2024
Merged
jackkleeman added a commit to jackkleeman/restate that referenced this issue Apr 16, 2024
@jackkleeman
Update opentelemetry libraries
4c64ce3 
otel has been released with the changes we needed, we can now avoid parsing header env var manually.

Fixes restatedev#1217
jackkleeman added a commit that referenced this issue Apr 16, 2024
@jackkleeman
Update opentelemetry libraries (#1406)
6bb5b87 
* Update opentelemetry libraries

otel has been released with the changes we needed, we can now avoid parsing header env var manually.

Fixes #1217

* Use clustername/nodename as the instance id in otel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackkleeman jackkleeman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update opentelemetry libraries jackkleeman/restate
1 participant
@jackkleeman