Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump the Arrow registry itself as part of the generated code #2368

Closed
teh-cmc opened this issue Jun 11, 2023 · 1 comment
Closed

Dump the Arrow registry itself as part of the generated code #2368

teh-cmc opened this issue Jun 11, 2023 · 1 comment

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 11, 2023

We build up the Arrow registry as part of the codegen process in order to be able to resolve datatypes.

The next step is to quote it directly into the generated code so that we can run meta queries at runtime (e.g. register.get_datatype("rerun.components.Point2D")?.

@nikolausWest nikolausWest removed the good first issue Good for newcomers label Jul 14, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 9, 2023

Build-time registries don't really make sense in our brand new dynamic world where one can just send arbitrary arrow data anyway (also opens the door to all kind of nasty problems e.g. different schema versions across clients & viewer etc).

Runtime schema registries as well as deduplication still very much makes sense though, see:

Once this is in place, adding extra runtime-introspection APIs on top is trivial.

@teh-cmc teh-cmc closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants