From f1e0a7070781975a07efe280f3cd185d426c9df1 Mon Sep 17 00:00:00 2001 From: Clement Rey Date: Wed, 11 Oct 2023 19:34:45 +0200 Subject: [PATCH] Pass over zombie TODOs for `0.9.1` (#3801) - Fixes #3800 --- crates/re_arrow_store/src/store_write.rs | 6 ----- crates/re_log_types/src/data_table.rs | 4 ++-- crates/re_tuid/src/lib.rs | 2 +- .../rerun/log_deprecated/transform.py | 23 ++++++++++++++++++- 4 files changed, 25 insertions(+), 10 deletions(-) diff --git a/crates/re_arrow_store/src/store_write.rs b/crates/re_arrow_store/src/store_write.rs index dda80e919de5..fd45e19c02fc 100644 --- a/crates/re_arrow_store/src/store_write.rs +++ b/crates/re_arrow_store/src/store_write.rs @@ -216,12 +216,6 @@ impl DataStore { } else { // Cache miss! Craft a new instance keys from the ground up. - // TODO(#1712): That's exactly how one should create a cell of instance keys… - // but it turns out that running `TryIntoArrow` on a primitive type is orders of - // magnitude slower than manually creating the equivalent primitive array for some - // reason… - // let cell = DataCell::from_component::(0..len as u64); - // ...so we create it manually instead. let values = arrow2::array::UInt64Array::from_vec((0..num_instances as u64).collect_vec()) diff --git a/crates/re_log_types/src/data_table.rs b/crates/re_log_types/src/data_table.rs index 5e96ff6aad5c..9acdab868d2f 100644 --- a/crates/re_log_types/src/data_table.rs +++ b/crates/re_log_types/src/data_table.rs @@ -926,7 +926,7 @@ impl DataTable { (&**chunk.get(control_index(COLUMN_ROW_ID)?).unwrap()).try_into_collection()?; let col_entity_path = (&**chunk.get(control_index(COLUMN_ENTITY_PATH)?).unwrap()).try_into_collection()?; - // TODO(#1712): This is unnecessarily slow… + // TODO(#3741): This is unnecessarily slow… let col_num_instances = (&**chunk.get(control_index(COLUMN_NUM_INSTANCES)?).unwrap()).try_into_collection()?; @@ -1005,7 +1005,7 @@ impl DataTable { .downcast_ref::>() .ok_or(DataTableError::NotAColumn(component.to_string()))? .iter() - // TODO(#1805): Schema metadata gets cloned in every single array. + // TODO(#3741): Schema metadata gets cloned in every single array. // This'll become a problem as soon as we enable batching. .map(|array| array.map(|values| DataCell::from_arrow(component, values))) .collect(), diff --git a/crates/re_tuid/src/lib.rs b/crates/re_tuid/src/lib.rs index 97c9ac4990c6..b78595d4a01b 100644 --- a/crates/re_tuid/src/lib.rs +++ b/crates/re_tuid/src/lib.rs @@ -24,7 +24,7 @@ pub struct Tuid { #[cfg(feature = "arrow2_convert")] arrow2_convert::arrow_enable_vec_for_type!(Tuid); -// TODO(#1774): shouldn't have to write this manually +// TODO(#3741): shouldn't have to write this manually #[cfg(feature = "arrow2_convert")] impl arrow2_convert::field::ArrowField for Tuid { type Type = Self; diff --git a/rerun_py/rerun_sdk/rerun/log_deprecated/transform.py b/rerun_py/rerun_sdk/rerun/log_deprecated/transform.py index c4ac16e412ee..980d8c85455a 100644 --- a/rerun_py/rerun_sdk/rerun/log_deprecated/transform.py +++ b/rerun_py/rerun_sdk/rerun/log_deprecated/transform.py @@ -22,10 +22,31 @@ from rerun.recording_stream import RecordingStream # Legacy alias for `TranslationAndMat3x3` -# TODO(#3275): Deprecation notices on these TranslationAndMat3 = TranslationAndMat3x3 +""" +!!! Warning "Deprecated" + Please migrate to [rerun.log][] with [rerun.TranslationAndMat3x3][]. + + See [the migration guide](https://www.rerun.io/docs/reference/migration-0-9) for more details. +""" + +# Legacy alias for `TranslationRotationScale3D` Rigid3D = TranslationRotationScale3D +""" +!!! Warning "Deprecated" + Please migrate to [rerun.log][] with [rerun.TranslationRotationScale3D][]. + + See [the migration guide](https://www.rerun.io/docs/reference/migration-0-9) for more details. +""" + +# Legacy alias for `Vec3D` Translation3D = Vec3D +""" +!!! Warning "Deprecated" + Please migrate to [rerun.log][] with [rerun.datatypes.Vec3D][]. + + See [the migration guide](https://www.rerun.io/docs/reference/migration-0-9) for more details. +""" __all__ = [