Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove golangci-lint from CI #1663

Closed
adamancini opened this issue Oct 25, 2024 · 1 comment · Fixed by #1677
Closed

remove golangci-lint from CI #1663

adamancini opened this issue Oct 25, 2024 · 1 comment · Fixed by #1677

Comments

@adamancini
Copy link
Member

from Marc:

org wide, we are not recommending or using golangci-lint. we’ve removed it from CMX and Vandoor

golangci-lint does add additional checks fwiw, but we seem to be disabling and ignoring most of them (and rightly so IMO, they aren’t providing a TON of value. for example, we have 100s of errors that we are ignoring a return value from a call. after looking at all of them (literally all of them in vendor-api), they all would be replaced with _ = While that’s more exact and specific, it not really making the product or code better.
And, i’d argue, that the Go language was pretty intentionally written to produce predictable code at Google. You can’t include an import that’s not used, you can’t have unused variables. Why did they make it ok to ignore errors when you choose? (I think it’s because it’s normal, and you should make that decision)

@adamancini
Copy link
Member Author

relates to this change 402d111

@xavpaice xavpaice linked a pull request Nov 7, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant