Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify a Pod's PriorityClass #172

Open
jangrewe opened this issue Apr 12, 2023 · 3 comments
Open

Add option to specify a Pod's PriorityClass #172

jangrewe opened this issue Apr 12, 2023 · 3 comments

Comments

@jangrewe
Copy link

I had to manually hardcode a priorityClassName in the code, as our cluster otherwise preempts the Pod during the rsync process.
It would be great if you could add an option to set that, or maybe even better: allow to specify a YAML template with all the bells and whistles that a Pod needs (labels, annotations, etc.) to be deployed successfully.

@laverya
Copy link
Member

laverya commented Apr 17, 2023

Supplying a pod template makes sense to not require a dozen features, but is there a good way to do that from the CLI?

passing in json/yaml is what I can think of, and that kind of sucks

@jangrewe
Copy link
Author

jangrewe commented Apr 17, 2023

I guess providing a YAML template trumps any other arguments one could wish for when creating a Pod, so i'd very much prefer that - also because i noticed a couple of labels and annotations that would be required to make a Pod a good citizen in our clusters. ;-)

Oh, and just to be sure: i'm talking about something like pvmigrate ... -template ./pod.yml

Maybe this is of help? https://medium.com/@harshjniitr/reading-and-writing-k8s-resource-as-yaml-in-golang-81dc8c7ea800

@laverya
Copy link
Member

laverya commented Apr 24, 2023

That does make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants