Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it easier to suggest changes to kurl.sh documentation pages #932

Open
adamancini opened this issue Jan 25, 2023 · 5 comments
Open

make it easier to suggest changes to kurl.sh documentation pages #932

adamancini opened this issue Jan 25, 2023 · 5 comments
Labels
type::feature New feature or request

Comments

@adamancini
Copy link
Member

adamancini commented Jan 25, 2023

the "View on GitHub" button at the top of https://kurl.sh points to https://github.com/replicatedhq/kurl; it should point to https://github.com/replicatedhq/kurl.sh instead

I think it would be a lot easier to make docs improvements on this site if the docs section on kurl.sh had the quick pr/issue link buttons on each page like docs.replicated.com has.

@AmberAlston
Copy link
Member

That behavior is intentional. We want it pointing at the core project source code repo vs the project website/docs repo. That matches a pattern of linking to the project's code repo established on our other open-source project landing pages like https://kots.io/ and https://troubleshoot.sh/

What challenge is not pointing to https://github.com/replicatedhq/kurl.sh presenting? For example is it making it harder to know where to edit the docs on kurl.sh? That would help us understand if there's alternative approaches to changing where that button is currently linking.

@adamancini
Copy link
Member Author

adamancini commented Jan 25, 2023 via email

@adamancini
Copy link
Member Author

adamancini commented Jan 25, 2023 via email

@AmberAlston
Copy link
Member

That's good feedback. I think it would be a lot easier to make docs improvements on this site if the docs section on kurl.sh had the quick pr/issue link buttons on each page like docs.replicated.com has.

There is an open conversation about the future of this kurl.sh site that could change the amount and/or scope of docs content we have on it today. It probably makes sense to make those decisions ahead of investing the time to add quick links or another path to easier kurl.sh docs prs like a secondary "View on Github" button.

cc @kyleprice and @replicatedhq/replicated-docs

@adamancini
Copy link
Member Author

adamancini commented Jan 26, 2023

@AmberAlston thanks! edited the issue title to reflect these thoughts

@adamancini adamancini added type::feature New feature or request and removed bug::normal labels Jan 26, 2023
@adamancini adamancini changed the title "View on Github" button on docs page links to wrong repo make it easier to suggest changes to kurl.sh documentation pages Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants