From 3fd1b5849b9f8d819ebcc823473203ae4c8d603f Mon Sep 17 00:00:00 2001
From: Mia Wong <miawongdev@gmail.com>
Date: Fri, 12 Jul 2024 19:30:14 +0000
Subject: [PATCH 1/2] fix type errors

---
 web/src/components/UploadLicenseFile.tsx            |  4 ++--
 .../snapshots/SnapshotStorageDestination.tsx        | 13 +++++++++++--
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/web/src/components/UploadLicenseFile.tsx b/web/src/components/UploadLicenseFile.tsx
index 08113fdfec..1cdd89ca03 100644
--- a/web/src/components/UploadLicenseFile.tsx
+++ b/web/src/components/UploadLicenseFile.tsx
@@ -508,13 +508,13 @@ const UploadLicenseFile = (props: Props) => {
                             <p className="u-fontSize--small u-textColor--bodyCopy u-lineHeight--normal u-marginBottom--10">
                               Select the application that you want to install.
                             </p>
-                            {/* TODO: there's probably a bug here*/}
-                            {/*@ts-ignore*/}
                             <Select
                               className="replicated-select-container"
                               classNamePrefix="replicated-select"
                               options={state.availableAppOptions}
                               getOptionLabel={(option) =>
+                                // We want to display element instead of string
+                                //  @ts-ignore
                                 getLabel(option.label)
                               }
                               getOptionValue={(option) => option.value}
diff --git a/web/src/components/snapshots/SnapshotStorageDestination.tsx b/web/src/components/snapshots/SnapshotStorageDestination.tsx
index 8b2e0245a2..a1a04f507e 100644
--- a/web/src/components/snapshots/SnapshotStorageDestination.tsx
+++ b/web/src/components/snapshots/SnapshotStorageDestination.tsx
@@ -103,6 +103,8 @@ type AWSStoreProvider = {
   other?: undefined;
   path?: string;
   bucket?: string;
+  internal?: boolean;
+  fileSystem?: string;
 };
 
 type GCPStoreProvider = {
@@ -116,6 +118,8 @@ type GCPStoreProvider = {
   azure?: undefined;
   other?: undefined;
   path?: undefined;
+  internal?: boolean;
+  fileSystem?: string;
 };
 
 type AzureStoreProvider = {
@@ -133,6 +137,8 @@ type AzureStoreProvider = {
   gcp?: undefined;
   other?: undefined;
   path?: undefined;
+  internal?: boolean;
+  fileSystem?: string;
 };
 
 type OtherStoreProvider = {
@@ -148,6 +154,8 @@ type OtherStoreProvider = {
   gcp?: undefined;
   azure?: undefined;
   path?: undefined;
+  internal?: boolean;
+  fileSystem?: string;
 };
 
 type StoreMetadata = {
@@ -1763,8 +1771,6 @@ class SnapshotStorageDestination extends Component<Props, State> {
                     )}
                   <div className="flex1">
                     {availableDestinations.length > 1 ? (
-                      // TODO: upgrade react-select and use the current typing
-                      // @ts-ignore
                       <Select
                         className="replicated-select-container"
                         classNamePrefix="replicated-select"
@@ -1772,6 +1778,9 @@ class SnapshotStorageDestination extends Component<Props, State> {
                         options={availableDestinations}
                         isSearchable={false}
                         getOptionLabel={(destination) =>
+                          // TODO: upgrade react-select and use the current typing
+                          // We want to display element instead of string
+                          // @ts-ignore
                           this.getDestinationLabel(
                             destination,
                             destination.label

From e0518c4d0b7ee7d63a547a5299cf7c2382af8b57 Mon Sep 17 00:00:00 2001
From: Mia Wong <miawongdev@gmail.com>
Date: Fri, 12 Jul 2024 19:40:29 +0000
Subject: [PATCH 2/2] internal, filesystem to undefined

---
 .../snapshots/SnapshotStorageDestination.tsx  | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/web/src/components/snapshots/SnapshotStorageDestination.tsx b/web/src/components/snapshots/SnapshotStorageDestination.tsx
index a1a04f507e..ba0ef68bda 100644
--- a/web/src/components/snapshots/SnapshotStorageDestination.tsx
+++ b/web/src/components/snapshots/SnapshotStorageDestination.tsx
@@ -103,8 +103,8 @@ type AWSStoreProvider = {
   other?: undefined;
   path?: string;
   bucket?: string;
-  internal?: boolean;
-  fileSystem?: string;
+  internal?: undefined;
+  fileSystem?: undefined;
 };
 
 type GCPStoreProvider = {
@@ -118,8 +118,8 @@ type GCPStoreProvider = {
   azure?: undefined;
   other?: undefined;
   path?: undefined;
-  internal?: boolean;
-  fileSystem?: string;
+  internal?: undefined;
+  fileSystem?: undefined;
 };
 
 type AzureStoreProvider = {
@@ -137,8 +137,8 @@ type AzureStoreProvider = {
   gcp?: undefined;
   other?: undefined;
   path?: undefined;
-  internal?: boolean;
-  fileSystem?: string;
+  internal?: undefined;
+  fileSystem?: undefined;
 };
 
 type OtherStoreProvider = {
@@ -154,8 +154,8 @@ type OtherStoreProvider = {
   gcp?: undefined;
   azure?: undefined;
   path?: undefined;
-  internal?: boolean;
-  fileSystem?: string;
+  internal?: undefined;
+  fileSystem?: undefined;
 };
 
 type StoreMetadata = {
@@ -164,8 +164,8 @@ type StoreMetadata = {
   azure?: undefined;
   other?: undefined;
   bucket?: string;
-  internal?: boolean;
-  fileSystem?: string;
+  internal?: undefined;
+  fileSystem?: undefined;
   path?: string;
 };