Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchroom update (not displaying elo gain/loss) #117

Open
invisible-defects opened this issue Jan 28, 2022 · 30 comments
Open

Matchroom update (not displaying elo gain/loss) #117

invisible-defects opened this issue Jan 28, 2022 · 30 comments

Comments

@invisible-defects
Copy link

invisible-defects commented Jan 28, 2022

Faceit have recently changed their match lobby UI and estimated elo gain/loss isn't displayed anymore.

chrome_ZADPHPVG1Z

@invisible-defects invisible-defects changed the title Matchroom update Matchroom update (not displaying elo gain/loss) Jan 28, 2022
@tunglv-1933
Copy link

@UnimaginaryUnit
i fixed ASAP.
https://github.com/leedrum/faceit-enhancer/raw/fix-show-elo-estimation/faceit-enhancer-fixed-show-elo-estimation.zip
u can download it from the link above and load unpacked in manage extensions
or
https://github.com/leedrum/faceit-enhancer if u know about Reactjs

@rpkaul
Copy link

rpkaul commented Feb 27, 2022

@tunglv-1933 after loading your zip file in chrome i am getting this error

@leedrum
Copy link

leedrum commented Feb 28, 2022

@rpkaul just ignore that error.
btw, Faceit changes DOM so many times => I need to update code. (I have just updated)
if you don't see the detail of match like this, pls visit the link above and do the steps again.
Example for me
Screen Shot 2022-02-28 at 16 02 08

Thx for the feedback.

@rpkaul
Copy link

rpkaul commented Feb 28, 2022

@leedrum i am using your fix elo branch and its working fine now <3 thank you for the update

@leedrum
Copy link

leedrum commented Mar 1, 2022

@invisible-defects @rpkaul
i updated new code

@rpkaul
Copy link

rpkaul commented Mar 1, 2022

@leedrum I was about to message you , because Faceit updated few thing yesterday and that broke this code again, but now its working fine.
Thank you so much for your lovely work :)

@rpkaul
Copy link

rpkaul commented Mar 1, 2022

@leedrum one more thing, your code is working fine for 5v5 ranked game but its not working for HUB Games where captains pick players after that they do map veto , if possible check that once

@leedrum
Copy link

leedrum commented Mar 1, 2022

@rpkaul I have not ever played the HUB game but I think it is a custom match => ELO won't be changed.

@rpkaul
Copy link

rpkaul commented Mar 1, 2022

@leedrum if hub is verified then ELO will be effected and now days lots of players playing in HUBs bcz of fast admin support and better matchmaking and no one can smurf there also bcz hub admins verify your faceit id , also in hub you get leaderboard thing where u get money and skins too.
thats why i was saying if you want or if possible then please check

@rpkaul
Copy link

rpkaul commented Mar 7, 2022

@leedrum hey bro can add these two PR in your recent fix elo branch?
#85
#93

@leedrum
Copy link

leedrum commented Mar 7, 2022

@rpkaul sr, I missed.

@leedrum if hub is verified then ELO will be effected and now days lots of players playing in HUBs bcz of fast admin support and better matchmaking and no one can smurf there also bcz hub admins verify your faceit id , also in hub you get leaderboard thing where u get money and skins too. thats why i was saying if you want or if possible then please check

I must have a match link to check data to modify the code. if u have, pls send it to me ASAP.

@leedrum hey bro can add these two PR in your recent fix elo branch? #85 #93

oh, I will check later at this weekend.

@rpkaul
Copy link

rpkaul commented Mar 7, 2022

I must have a match link to check data to modify the code. if u have, pls send it to me ASAP.

MatchRoom Links-
https://www.faceit.com/en/csgo/room/1-5793d788-b434-4e67-a3e4-f596faa33f3e
https://www.faceit.com/en/csgo/room/1-2748fbe2-b4df-4f0b-9047-5c555882e3f0

@leedrum hey bro can add these two PR in your recent fix elo branch? #85 #93

oh, I will check later at this weekend.

Thank you 👍

@rufatalv
Copy link

@leedrum can u tell me how u fixed it mate?
I'm beginner developer and i want to know(

@leedrum
Copy link

leedrum commented Mar 11, 2022

@rpkaul The matches above don't affect ELO. I tested on the real-time match and observe. It seems still OK (you can check the video below).
About "Bans history", the PR above has an error (it uses an old response from Faceit). But I fixed it (check the image below).
You should re-do the steps to update the extension.

  • Video:
Screen.Recording.2022-03-11.at.17.26.10.mov
  • Image:

Screen Shot 2022-03-11 at 17 25 16

@leedrum
Copy link

leedrum commented Mar 11, 2022

@rufatalv
The problem is Faceit changed DOMs => extension can't display to the match info area anymore.
I just correct the query selector. you can check my commit here

@rpkaul
Copy link

rpkaul commented Mar 11, 2022

@leedrum idk but its not working for my HUB , leave it its working fine for ranked game so yes its good , also yes ban history is working fine thank you.

@ghost
Copy link

ghost commented Apr 26, 2022

@rufatalv The problem is Faceit changed DOMs => extension can't display to the match info area anymore. I just correct the query selector. you can check my commit here

can u post link to directly load your branch, i dont know how install on firefox pls

@leedrum
Copy link

leedrum commented Apr 26, 2022

@popoyeLetal it is here
for firefox, u can load like the steps below

  1. Open about:debugging#addons
  2. Click on Load Temporary Add-on
  3. Select the manifest.json file

@leedrum
Copy link

leedrum commented Jun 23, 2022

UPDATED: I fixed auto accept party invite

@AlessandroKa
Copy link

@leedrum Thanks for the updated version, it works great!

@rpkaul
Copy link

rpkaul commented Sep 19, 2022

@leedrum sorry to ping you again, but this broken again
can you please fix it ?
also i added you on discord so i can ping you there for future

@Icytreez
Copy link

@leedrum not working now =( in Chrome browser

@leedrum
Copy link

leedrum commented Sep 19, 2022

@rpkaul @Icytreez ok, I'm on a vacation. I will check it tomorrow.
@rpkaul Discord? I don't have any friend request.

@leedrum
Copy link

leedrum commented Sep 20, 2022

@rpkaul @Icytreez I fixed it.
u guys can re-install the extension to update the latest code.
Link download: Lastest extension
btw, I'm going to publish an extension to chrome store. your extension will be auto-updated via ChromeStore.
p/s: I mailed to @timche but I don't receive any response from him.

@rpkaul
Copy link

rpkaul commented Sep 20, 2022

checking now , bdw i added yopu on steam
kanchatory

EDIT - WORKING FINE

@leedrum
Copy link

leedrum commented Sep 21, 2022

Updated lastest version:
https://github.com/leedrum/faceit-enhancer/blob/v2.11.8/faceit-enhancer-fixed-show-elo-estimation.zip
note:

  • re-show Elo estimation
  • re-add "newElo" for free account

@timche
Copy link
Collaborator

timche commented Sep 21, 2022

@leedrum can you please add me on Discord (timche#2098)? I'd like to discuss with you the future of this project.

@leedrum
Copy link

leedrum commented Sep 22, 2022

@timche done, I'm waiting for you

@Sn3w233
Copy link

Sn3w233 commented Sep 26, 2022

Could you add me to I need help to fix the match rooms Sn3w#9193

@leedrum
Copy link

leedrum commented Sep 26, 2022

@Sn3w233 done, pls check. btw, I'm working, so I may not reply immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants