Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appkit iOS eth_sendTransaction not working with trust wallet #88

Open
msalman-mufin opened this issue Jan 22, 2025 · 5 comments
Open

Appkit iOS eth_sendTransaction not working with trust wallet #88

msalman-mufin opened this issue Jan 22, 2025 · 5 comments
Assignees
Labels
appkit AppKit related issue bug Something isn't working

Comments

@msalman-mufin
Copy link

SDK Affected
AppKit

Describe the bug

Appkit connect works in trust wallet eth_sendTransaction method not working.

To Reproduce

Steps to reproduce the behavior:

  1. Go to connect trust wallet with Flutter appkit (example) version 3.0.0 Build 45 (test flight)
  2. Click on on network select polygon, and click connect.
  3. After connect select eth_sendTransaction it will open trust wallet but wont show anything further.
  4. When you comeback on Flutter Appkit you will see error popup

Expected behavior

Should show transaction popup in trust wallet

Reproducible code

you can download flutter appkit example from test flight https://testflight.apple.com/join/6aRJSllc

Screenshots

https://www.loom.com/share/19dbbc6ae41c4176a5f993aff56d5e66?sid=8b6a1f43-cdb7-4836-b710-3ec9cfde61b6

Smartphone (please complete the following information):

  • Device: iPhone12
  • OS: iOS 18.0.1
  • Browser: Flutter Appkit example
  • Version 3.0.0 Build 45
Copy link

linear bot commented Jan 22, 2025

@quetool
Copy link
Member

quetool commented Jan 22, 2025

Hello @msalman-mufin, thanks for reporting, is this happening only with Trust wallet?

@msalman-mufin
Copy link
Author

Hey @quetool , other than trust wallet I tested with meta mask which works very fine.
Also I cross checked Wallet connect's Dapp which works fine.

@quetool
Copy link
Member

quetool commented Jan 23, 2025

Hello @msalman-mufin thanks! It is indeed an issue on Trust side. If you add 0x as data in your transaction it will work. I'll reach out to them to let them know about this issue.

@quetool quetool mentioned this issue Jan 23, 2025
2 tasks
@quetool quetool self-assigned this Jan 23, 2025
@quetool quetool added the investigation Investigation needed label Jan 23, 2025
@quetool
Copy link
Member

quetool commented Jan 23, 2025

Hello again @msalman-mufin! It turns out this is not an issue on Trust side. Just a bug on AppKit sample Dapp (not on the SDK). data is required to be sent during eth_sendTransaction/eth_signTransaction as per specs https://docs.reown.com/advanced/multichain/rpc-reference/ethereum-rpc#eth_sendtransaction and we are missing it on the Sample Dapp. Thanks for catching this, we will fix it.

@quetool quetool added bug Something isn't working appkit AppKit related issue and removed investigation Investigation needed labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appkit AppKit related issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants