Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renegade_contracts: profiling: add breakpoints #86

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

akirillo
Copy link
Contributor

@akirillo akirillo commented Sep 6, 2023

This PR adds the notion of "breakpoints" for key execution components we want to profile, providing an option to return early from our contract functions to get execution resource usage up to that point from the Katana devnet node.

The reason this is done in-process with an enum is so that, when running the test/profiling suite, we can declare/deploy the contracts once and load state on subsequent profiling runs, instead of literally hardcoding an early return in the contracts and having to redeclare/redeploy every time we move it.

Incorporating this change into the e2e tests / a small profiling suite is left for the next PR, so that any suggestions can be made here first.

@akirillo akirillo added the enhancement New feature or request label Sep 6, 2023
@akirillo akirillo requested a review from joeykraut September 6, 2023 00:38
@akirillo akirillo self-assigned this Sep 6, 2023
@akirillo akirillo removed the request for review from joeykraut September 6, 2023 00:46
@akirillo akirillo merged commit ce10c52 into profiling Sep 6, 2023
1 check passed
@akirillo akirillo deleted the andrew/init-breakpoints branch September 6, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant