Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineCss middleware breaks Alpine JS #154

Open
amiranagram opened this issue Apr 19, 2021 · 0 comments
Open

InlineCss middleware breaks Alpine JS #154

amiranagram opened this issue Apr 19, 2021 · 0 comments

Comments

@amiranagram
Copy link

amiranagram commented Apr 19, 2021

Detailed description

From my understanding after giving it a quick look, this middleware combines duplicate attributes into one, for a single tag. Well this also combines Alpine's x-bind:attribute which is undesired when working with Alpine.

Context

Pretty self explanatory, anyone using Alpine JS in their project, or similar packages that utilize custom attributes will have this issue.

Possible implementation

For starter we could ignore tags that contain :.
I don't know any other packages that do the same job as Alpine JS does, but these days Alpine JS is goto for Laravel developers and maybe a fix for Alpine only would be enough.

Your environment

To reproduce check out this pen and copy the code inside a Laravel project utilizing the InlineCss middleware. Also check out my issue in Alpine JS repo to see the full context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant