Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emp tool silently fails when trying to deploy w/o a commit message #1121

Closed
sumeet opened this issue Feb 27, 2018 · 1 comment
Closed

emp tool silently fails when trying to deploy w/o a commit message #1121

sumeet opened this issue Feb 27, 2018 · 1 comment
Labels
bug

Comments

@sumeet
Copy link
Contributor

sumeet commented Feb 27, 2018

emp-staging deploy remind101/r101-api:latest -a r101-api exits silently with code 0, but doesn't actually do anything. turns out it requires a -m to actually trigger a deploy

this bug was related to the incident recently where we deployed an ancient version of

the return 0 is misleading, seems like the deploy actually happened when nothing happened. can we fix this in the client?
@ejholmes ejholmes added the bug label Feb 27, 2018
@ejholmes
Copy link
Contributor

Turns out we already have an issue open for this: #1119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sumeet @ejholmes