Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better implementation for base_files #303

Open
bilogic opened this issue Oct 28, 2024 · 0 comments
Open

Better implementation for base_files #303

bilogic opened this issue Oct 28, 2024 · 0 comments

Comments

@bilogic
Copy link

bilogic commented Oct 28, 2024 •
edited
Loading

The base_files is great, I have a few suggestions to add on:

  1. Make the base model classes abstract so that no one can accidentally use it
    2. Append Base to the classname, e.g. App\Models\Base\ExampleBase.php
    3. Create the App\Models\Example model if it does not exists and have it extend from Base\ExampleBase

Seems 2 and 3 already happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bilogic