Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue-on-error type should be Optional <Bool | Text>? #43

Open
zeeshanlakhani opened this issue Jun 10, 2021 · 3 comments
Open

continue-on-error type should be Optional <Bool | Text>? #43

zeeshanlakhani opened this issue Jun 10, 2021 · 3 comments

Comments

@zeeshanlakhani
Copy link
Contributor

There are instances where you'd like the continue-on-error field in a job to reference a matrix variable for example that can itself be true or false. However, with the current type being Optional Bool, there's no way to take-in a \${{matrix.blah}} Text/String.

I thought about adding a PR, but wanted to throw up an issue first and get your thoughts.

@regadas
Copy link
Owner

regadas commented Jun 26, 2021

Hi @zeeshanlakhani sorry for the late reply! Lately time has been scarse!

I can see the use case and it's usefulness; Not sure if you still want to give a go! I would love to see your take on it!

@zeeshanlakhani
Copy link
Contributor Author

@regadas no worries at all. Yeah, I'm in the midst of a paper deadline, but maybe if I get some time in between or after for sure. I've already been talking to @joedevivo about it as we start using more dhall for our CI generation at work :).

@samhh
Copy link

samhh commented May 5, 2022

The same goes for cancel-in-progress in Concurrency, for example:

concurrency:
  group: ${{ github.ref }}
  cancel-in-progress: ${{ github.event_name == 'pull_request' }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants