fix: ensure CreateButton respects disabled prop in UI packages #6515
+79
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c7f570d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hello @OmkarBansod02, thanks for the improving Refine! the PR needs a changeset to release packages. https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset |
alicanerdurmaz
requested changes
Nov 22, 2024
There was a problem hiding this comment.
we need tests for these changes
test files for buttons here: https://github.com/refinedev/refine/tree/master/packages/ui-tests/src/tests/buttons
…/OmkarBansod02/refine into fix-create-button-disabled-issue
…/OmkarBansod02/refine into fix-create-button-disabled-issue
|
Hello @OmkarBansod02, Thanks for improving Refine, we will release this PR in the first week of December! |
alicanerdurmaz
changed the base branch from
master
to
releases/december-2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Create Button onClick still works when disabled prop is applied
What is the new behavior?
Create Button respects disabled prop in UI packages.
fixes #6513
Notes for reviewers