Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Your cart is empty" on checkout #204

Open
jtoar opened this issue Apr 29, 2022 · 2 comments
Open

Fix "Your cart is empty" on checkout #204

jtoar opened this issue Apr 29, 2022 · 2 comments

Comments

@jtoar
Copy link
Contributor

jtoar commented Apr 29, 2022

For some reason when you go to checkout, "Your cart is empty" is shown in the checkout dropdown:

image

This probably has something to do with the CartProvider, which uses XState.

@aggmoulik
Copy link

Hey @jtoar I am looking into this, will submit a PR.

@adriatic
Copy link

adriatic commented May 31, 2022

Two more comments:

  1. Should it be possible to stuff items into cart while not authenticated?
  2. Despite the "false" message that the cart is empty, it is possible to click on the checkout and move to the payment page.

The item 1 is by design (I guess), but 2. should not be - unless it is also by design,,, to allow non authenticated people to purchase and pay.

P.S. I do not plan to step on @aggmoulik turf 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants