Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying GitHub tokens #3650

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Unifying GitHub tokens #3650

merged 2 commits into from
Jan 1, 2024

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Dec 17, 2023

GitHub actions was requiring two sets of tokens, purely due to the historic migration from circleci to GH. This pull requests closes the duplication. Note, immediately after this change, the secrets are update in GitHub, with the new GPG key.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc68b11) 75.38% compared to head (64a7fe5) 75.38%.

❗ Current head 64a7fe5 differs from pull request most recent head 9ce32e9. Consider uploading reports for the commit 9ce32e9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3650   +/-   ##
=========================================
  Coverage     75.38%   75.38%           
- Complexity     4895     4896    +1     
=========================================
  Files           297      297           
  Lines         14965    14965           
  Branches       1129     1130    +1     
=========================================
+ Hits          11281    11282    +1     
+ Misses         3189     3188    -1     
  Partials        495      495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 93fa07e into master Jan 1, 2024
3 checks passed
@sazzad16 sazzad16 deleted the ck-unifynex branch January 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants