-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLUSTER SHARDS command support (#2984) #3598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising!
src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java
Outdated
Show resolved
Hide resolved
@wormogig Please address the remaining 2 change requests and keep the others as is. |
src/test/java/redis/clients/jedis/commands/jedis/ClusterCommandsTest.java
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3598 +/- ##
============================================
+ Coverage 71.52% 71.60% +0.08%
- Complexity 4851 4883 +32
============================================
Files 288 290 +2
Lines 15461 15610 +149
Branches 1095 1115 +20
============================================
+ Hits 11058 11178 +120
- Misses 3927 3946 +19
- Partials 476 486 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Command CLUSTER SHARDS added to ClusterCommands and command CLUSTER SLOTS marked as depricated.