Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-cast the Pipeline object in JedisSentineled #3517

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

sazzad16
Copy link
Collaborator

This is an expansion of #3221, as well as #3240. This is requested in #3516.

This is an expansion of redis#3221, as well as redis#3240. This is requested in redis#3516.
@sazzad16 sazzad16 added this to the 4.4.x milestone Aug 31, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (c920bb3) 71.15% compared to head (e42aa81) 71.14%.

❗ Current head e42aa81 differs from pull request most recent head cbc3372. Consider uploading reports for the commit cbc3372 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3517      +/-   ##
============================================
- Coverage     71.15%   71.14%   -0.02%     
+ Complexity     4761     4760       -1     
============================================
  Files           277      277              
  Lines         15008    15009       +1     
  Branches       1057     1057              
============================================
- Hits          10679    10678       -1     
- Misses         3863     3864       +1     
- Partials        466      467       +1     
Files Changed Coverage Δ
...main/java/redis/clients/jedis/JedisSentineled.java 50.00% <0.00%> (-7.15%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 58c375e into redis:master Aug 31, 2023
4 checks passed
@sazzad16 sazzad16 deleted the sentinel-pipeline branch August 31, 2023 11:43
sazzad16 added a commit that referenced this pull request Aug 31, 2023
This is an expansion of #3221, as well as #3240. This is requested in #3516.
@sazzad16 sazzad16 modified the milestones: 4.4.x, 4.4.4 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants