tuned-ppd: Disallow releasing profile holds of other processes #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacikpa
force-pushed
the
ppd-fix-cookies
branch
from
73489be to
466fea3
Compare
zacikpa
changed the title
zacikpa
force-pushed
the
ppd-fix-cookies
branch
3 times, most recently
from
150411a to
0380ba2
Compare
Add a check which raises an error if the caller of ReleaseProfile is not identical to the caller of HoldProfile. Do not number cookies from 0, use pseudo-random integers. Do not allow null cookies, which may cause issues in clients. E.g., in gnome-settings-daemon, a null cookie means that it currently has no active hold.
zacikpa
force-pushed
the
ppd-fix-cookies
branch
from
0380ba2 to
3535365
Compare
|
Thanks LGTM, the CI failure seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check which raises an error if the caller of ReleaseProfile
is not identical to the caller of HoldProfile.
Do not number cookies from 0, use pseudo-random integers.
Do not allow null cookies, which may cause issues in clients.
E.g., in gnome-settings-daemon, a null cookie means that it
currently has no active hold.