Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifact rules enable --config should only propose values for specific rule #1440

Open
wtrocki opened this issue Feb 15, 2022 · 1 comment
Open

Artifact rules enable --config should only propose values for specific rule #1440

wtrocki opened this issue Feb 15, 2022 · 1 comment
Labels
enhancement New feature or request feature/service-registry

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 15, 2022 •
edited
Loading

Feature or problem description

When creating suggestion we can use opts.ruleType value to determine what rule we deal with
@wtrocki wtrocki added the enhancement New feature or request label Feb 15, 2022
@wtrocki
Copy link
Collaborator Author

wtrocki commented Mar 24, 2022

Issue is that rhoas servivce-registry artifact rules enable --config= suggestions show more values than they should.
We have method that calculates those values:

app-services-cli/pkg/cmd/registry/rule/rulecmdutil/flagset.go

Line 70 in 623d759

return ruleTypes, cobra.ShellCompDirectiveNoSpace

@gowriswarupk gowriswarupk mentioned this issue Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature/service-registry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wtrocki @rkpattnaik780 @gowriswarupk @app-services-ci