ocp4_workload_rhacm_hypershift: Support OCP 4.17 AWS authn #8819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…{namespace: local-cluster, secret: aws-credentials}",
* add ocp version condition * remove use of --secret-creds (for now) * add sts-creds, pull-secret, role-arn
don't rely on subdomain_base use subdomain_base_suffix and remove leading . with regex_replace
rhjcd
approved these changes
Nov 13, 2024
agonzalezrh
pushed a commit
that referenced
this pull request
Nov 21, 2024
* most setup - failing on Error: the aws_session_token key is invalid, {namespace: local-cluster, secret: aws-credentials}",
* hcp create cluster aws 4.17
* add ocp version condition
* remove use of --secret-creds (for now)
* add sts-creds, pull-secret, role-arn
* prep aws roles: add pull request
* secret-aws-credentials.yaml
don't rely on subdomain_base
use subdomain_base_suffix and remove leading . with regex_replace
* fix indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features to enable
hcpfrom OCP 4.17, which uses new AWS Roles to control HCP deployments.ALSO tested against sandboxes-gpte/hol-ocp-plus development catalog item. That prod tag can move without calamity.