-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map: Tapping amenities doesn't clear stage card or active state of stage pin (and amenities pin doesn't have an active state) #566
Comments
Do we have active state versions of the amenities markers? |
@abinocoe Don't think so. @JunBadger Did we do active states for the amenities pins? |
Added active WC: zpl://screen?sid=5b3b995b82f94ee8a236e8c0&pid=5a916701f75c524181eebe68 and active first aid: zpl://screen?sid=5b3b995c2ff711764b6bf8f0&pid=5a916701f75c524181eebe68 |
Updated issue with: OS / Browser / Model |
awesome, ty @JunBadger |
yeah, strangely @abinocoe Golden Sq is the only event that doesn't become inactive/ event card doesn't disappear - but only if you then click on the overlapping WC or first aid tent (for iphone X) |
Description of issue
When I tap a stage pin on the map the stage card appears. When I then tap an amenities pin the stage card remains and the stage pin remains active. This is confusing as it's not clear my tap has registered as there is little feedback from the UI.
Expected behaviour
I'd expect the stage card to be removed and the stage pin to become inactive when I tap an amenities pin.
I'd expect the amenities pin to have an active state so it's clear what has been tapped.
Steps to reproduce
Go to map
Tap stage pin
Tap amenities pin
Observe stage card isn't removed and stage pin is still active
OS / Browser / Device model
Steve's Pixel
iphoneX - just happens on Golden Square event
Screenshots
The text was updated successfully, but these errors were encountered: