Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Performance: Event filter selection is slow to update #403

Open
declanslevin opened this issue Jun 8, 2018 · 1 comment
Open

Comments

@declanslevin
Copy link
Contributor

Description of issue

Selecting filter options in the Event filter is slow to update on Android. On iOS they update state immediately.

Expected behaviour

Filter options should update immediately when selected.

Steps to reproduce

  • Open the event filter (filter by area, price...)
  • Quickly tap on a few

Delay in marking them as selected

OS / Browser / Device model

Galaxy S8

@RGBboy
Copy link
Contributor

RGBboy commented Jun 11, 2018

This is likely related to recalculating all the events that the filter applies to. Hopefully this will be somewhat mitigated by sharing a memoized view of these across screens so that we only calculate this once. However, rapid changes to the filters may still cause a backlog of these calculations. If so, one solution is to debounce the calculation of filtered events. We could immediately update the state of the filters, but delay the applying to the calculated events, if the user is interacting rapidly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants