Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of Menu scene #96

Open
11 tasks
jesstice opened this issue Sep 18, 2017 · 0 comments
Open
11 tasks

Review of Menu scene #96

jesstice opened this issue Sep 18, 2017 · 0 comments
Assignees
@plinioprado
Labels
Review

Comments

@jesstice
Copy link
Member

jesstice commented Sep 18, 2017 •
edited
Loading

  • Fix - it doesn't stay on the bottom
  • White background doesn't extend to the bottom
  • Icons are cut off a bit - change the overflow
  • Review prop types
  • Review indentation (4 spaces)
  • Review font, font size, font colour
  • Check for semi-colons
  • Check for extra spaces... and remove them!
  • Check the problems tab
  • Check against original design
  • Review for any other issues...!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plinioprado plinioprado

Labels
Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jesstice @plinioprado