Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: adding exclaimation mark to test with warnings to help spotting them #173

Open
8749236 opened this issue Nov 26, 2023 · 1 comment

Comments

@8749236
Copy link

8749236 commented Nov 26, 2023

A test case with warning.

<?php declare(strict_types=1);
use PHPUnit\Framework\TestCase;


class SampleTest extends TestCase
{
    public function testCase1()
    {
        $bytes .= 1;
        $this->assertEquals(
            1,
            1
        );
    }
}

Run the test will show this:
image
image

Expected behavior:
When test result says there are issues or warnings, mark them with an exclaimation mark in yellow circle (or other symbols that you prefer).
If you can fish out the stack trace, it will be even better.
Example drawing:
image

@8749236 8749236 changed the title Difficulty spotting test with warnings since they are marked with green checkmark Request adding exclaimation mark to test with warnings to help spotting them Nov 26, 2023
@8749236 8749236 changed the title Request adding exclaimation mark to test with warnings to help spotting them Feature request: adding exclaimation mark to test with warnings to help spotting them Nov 26, 2023
@sfsaccone
Copy link

Indicating deprecations (from the PHPUnit options --display-deprecations and or --display-phpunit-deprecations) would also be helpful. Otherwise, after seeing all green checkmarks, I have to run phpunit on the command line to show these. Separate icons for warnings, deprecations, etc., would particularly helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants