Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use original rbs2-corr-id for trace-state/parent-id #15

Open
riezebosch opened this issue Mar 28, 2023 · 2 comments
Open

Why not use original rbs2-corr-id for trace-state/parent-id #15

riezebosch opened this issue Mar 28, 2023 · 2 comments

Comments

@riezebosch
Copy link
Contributor

https://github.com/rebus-org/Rebus/blob/master/Rebus/Messages/Headers.cs#L26

Instead of using another custom header.

@riezebosch riezebosch changed the title Use original rbs2-corr-id for trace-state/parent-id Why not use original rbs2-corr-id for trace-state/parent-id Mar 28, 2023
@zlepper
Copy link
Collaborator

zlepper commented Apr 19, 2024

Mainly backwardscompatibility. You never know what might depend on something, so in case messages are being based to/from services that doesn't have open telemetry enabled, we are not going to conflict with any custom logic. Though the question is still valid.

@mookid8000 Would there be anything wrong with co-opting the mentioned header for this?

@mookid8000
Copy link
Member

@zlepper I have no idea, actually. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants