This repository has been archived by the owner on May 12, 2018. It is now read-only.
Adapt erlydtl compiler plugin to latest version of erlydtl #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaos
referenced
this pull request
in kaos/ChicagoBoss
Feb 4, 2014
The `erlydtl:compile_dir` function was fixed in 0.8.2. Fixes ChicagoBoss#419. Also, the `report` and `return` options should now go directly into the erlydtl options, rather than into the `compiler_options` property; otherwise those options will not be treated by erlydtl, but only affect the erlang compiler, which is not what you want.
|
Thanks, this looks reasonable to me, assuming the compatibility fix won't cause any issues due to duplicate/conflicting options. Stylististically, can you remove the period in the commit title/summary (see CONTRIBUTING). cc @jaredmorrow |
|
Dropped ending period from commit message, and changed link to use https. Unknown options are silently dropped/disregarded, so no harm there. |
|
There was a subtle bug in the mixed handling of proplists vs lists that @davidw was kind enough to resolve. |
|
This pull would also address the issue reported in basho/rebar#393. |
kaos
referenced
this pull request
in davidw/rebar
Feb 14, 2014
kaos
referenced
this pull request
in davidw/rebar
Feb 14, 2014
|
Yes, I believe it is. |
|
+1 Lets do it! What maintainer can we alert to push the button? |
jaredmorrow
added a commit
that referenced
this pull request
Feb 24, 2014
Adapt erlydtl compiler plugin to latest version of erlydtl
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest as of the time of this pull request was 0.8.1 (a 0.8.2 has recently been released which fixes the
compile_dirfunction; which rebar doesn't use however).