-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release with 5.1 compatibility #438
Comments
Currently mdx depends on the compiler internals and, as it is, mdx will also require updates to work with OCaml 5.2, so this problem is going to repeat soon. I would personally recommend to
|
Thanks for the comment. Ping @talex5 |
I support your first point. I think for the latter is too late, since many projects are now using mdx to use the documentation also as a testing tool |
The mdx tool, as it is, requires constant maintenance to keep up with the compiler internals and mdx is not, to my knowledge, currently actively maintained. Perhaps this changes in the future, but for now I personally do not recommend using mdx as a testing tool. As long as software is being maintained, it should not be too late to rewrite tests to use less fragile and maintenance heavy approaches. |
PR on opam-repository is at ocaml/opam-repository#24535 |
To comment on
Now that Dune supports cram test and that cram test support has been removed from mdx, the tool's primary purpose is indeed to run code blocks in documentation, and not to be a test runner. I've been curious about that: is there anything blocking Eio from using Dune cram tests in place of mdx? |
Eio will always have documentation, so it always needs to depend on a doc tester like mdx. So having a second testing system doesn't make things any more reliable, and cram tests look less convenient that mdx. What's the benefit? |
What is confusing in my opinion is craml is marked as deprecated and I'm directed to use mdx instead. The cram tests documentation for dune doesn't mention any deprecation, I can only assume because it uses something else? But it's not clear whether it is. I can create the equivalent documentation tests in mdx and they work the same as the dune cram tests. So which supported option should I use to test cli ocaml programs? |
@tmcgilchrist As someone who is new and just finally stumbled to this issue and comment. I agree. I was quite confused and thought I should be using |
Would it be possible to have a release of mdx with #435 ?
This would re-enable testing for a number of packages that where otherwise failing (and now are not tested due to newly introced upper bounds, see ocaml/opam-repository#24467)
The text was updated successfully, but these errors were encountered: