Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having OutboundMessage, can we rename Delivery as InboundMessage? #108

Open
gregturn opened this issue Aug 26, 2019 · 1 comment
Open

Having OutboundMessage, can we rename Delivery as InboundMessage? #108

gregturn opened this issue Aug 26, 2019 · 1 comment

Comments

@gregturn
Copy link

To have a little symmetry, can we rename Delivery to InboundMessage? And then AcknowledgeableDelivery could become AcknowledgeableInboundMessage.

I personally feel this would align better with OutboundMessage on the sending side.

Motivation

Having a consistent nomenclature (inbound/outbound, publisher/subscriber, producer/consumer) will help people pick up the API and run with it.
@acogoluegnes
Copy link
Contributor

Good point. Should go into 2.0, as it is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregturn @acogoluegnes