Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

navigation.dispatch, Go Back Not working #22

Open
soroushm opened this issue Apr 15, 2019 · 9 comments
Open

navigation.dispatch, Go Back Not working #22

soroushm opened this issue Apr 15, 2019 · 9 comments

Comments

@soroushm
Copy link

soroushm commented Apr 15, 2019

after i try to reuse my react-native project in web i found couple of issues on react-navigation

Example of project is here in codesandbox

issue 1 : (navigation.goBack not working)

app landing in transaction page and will be show 2 item:
on Press one item will be navigate to transactionDetails page with params and working as well
but on click back button on header navigation.goBack not working
step to reproduce: tansaction-> transactionDetails -> Back

issue 2: (NavigationService.reset not working)

after navigate to transaction detail and push navigation reset button reset not working like below issue:
#20
get reset from ref not working but navigationService.navigate working as well
step to reproduce: tansaction-> transactionDetails -> Navigation Reset

issue 3: (navigation with object params refresh issue)

in this case in url query string will be set [object Object] but after navigate in get params data is exsit and working fine in case landing with navigate
in refresh page app get exeption becouse there is no data
example : /TransactionDetail?transaction=[object Object]
step to reproduce : tansaction-> transactionDetails

issue 4: (navigation with string params when route inside other createSwitchNavigator)

in case navigate with params not working as well and params in undefiend but in refresh page get params from query string as well
step to reproduce: TopUp -> select Operator -> check operatorCode: (undefined | Number)

Your Environment

software version
react-navigation core "3.2.0"
react-navigation web "1.0.0-alpha.7"
react-native-web "0.11.2"
node 8
npm or yarn yarn
@soroushm
Copy link
Author

Hello @brentvatne

as your request i made example and details
please take a look on here

for navigation reset and go Back i try to figure out whats happend somting in look like evrey before dispatch working as well but dispatch not working

a Big Thanks

@brentvatne
Copy link
Member

brentvatne commented Apr 15, 2019

hi @soroushm! thank you for that. we're going to be doing a lot of work on this soon because web is becoming more important to us at expo (https://blog.expo.io/expo-cli-and-sdk-web-support-beta-d0c588221375) so i can justify spending time on it. i don't have an answer for your problem immediately though.

@soroushm
Copy link
Author

soroushm commented Apr 17, 2019

issue 3 will be fixed with this pull request #26

@unadlib
Copy link

unadlib commented Apr 21, 2019

So, may I ask when the fix version will be released?

@soroushm
Copy link
Author

@unadlib > So, may I ask when the fix version will be released?

temporary you can use window.history.back()

@mschipperheyn
Copy link

mschipperheyn commented Sep 23, 2019

@soroushm That has a tendency to create a lot of problems and we are experiencing them. Primarily, when back leads to the same page being reloaded. Is this perhaps already fixed on v4 or v5? If so, it's worth the upgrade. If not, not just yet.

@brentvatne
Copy link
Member

we still haven't had time to prioritize the web implementation, you might want to use react-router for web for now

@vomchik
Copy link

vomchik commented Feb 17, 2020

any news about this issue?

@soroushm
Copy link
Author

soroushm commented Feb 17, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants