New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing aria-haspopup #855

Open

romans12 wants to merge 3 commits into react-bootstrap:master from romans12:csb-f407s

romans12 commented Aug 19, 2020 •

edited

Loading

Resolves #854

romans12 added 3 commits

August 19, 2020 07:24


          initial commit

6762d10


          Fixing formatting of quotes.

6fba0c0


          Adding trailing commas back

38fba7a

Member

jquense commented Aug 19, 2020

should we conditionally add it for cases where the menu is actually a role=menu? We do some of that already, it may not be too much extra work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet