PR: gh#146 : Changes for linux message handler #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanjoe24
force-pushed
the
feature/gh146-key-handler
branch
3 times, most recently
from
8116a1b to
73cc33c
Compare
kanjoe24
force-pushed
the
feature/gh146-key-handler
branch
from
73cc33c to
67e0443
Compare
Ulrond
requested changes
Nov 25, 2024
kanjoe24
force-pushed
the
feature/gh146-key-handler
branch
2 times, most recently
from
361b39a to
f798c73
Compare
kanjoe24
force-pushed
the
feature/gh146-key-handler
branch
from
f798c73 to
f89f934
Compare
Ulrond
requested changes
Nov 28, 2024
keyhandler/keyhandler.c
Outdated
| } | ||
| break; | ||
| case 't': | ||
| type = optarg; |
There was a problem hiding this comment.
types must be checked against the valid list from the profile.
keyhandler/keyhandler.c
Outdated
| type = optarg; | ||
| break; | ||
| case 'c': | ||
| code = optarg; |
There was a problem hiding this comment.
the code input can only be from the based on profile the event type , otherwise it's an error.
| //ioctl(fd, UI_SET_KEYBIT, result_kvp); | ||
|
|
||
| memset(&usetup, 0, sizeof(usetup)); | ||
| usetup.id.bustype = BUS_USB; |
There was a problem hiding this comment.
can we swap this to the way that keySumulator works.. I think it may just use the dev, but someone needs to create it..
keyhandler/keyhandler.c
Outdated
|
|
||
| write(fd, &ie, sizeof(ie)); | ||
|
|
||
| ie.type = EV_SYN; |
There was a problem hiding this comment.
not clear why your doing the one this. And what is the bennifit you need to document more.
kanjoe24
force-pushed
the
feature/gh146-key-handler
branch
2 times, most recently
from
ba7bb26 to
b089424
Compare
kanjoe24
force-pushed
the
feature/gh146-key-handler
branch
from
b089424 to
6cfcdae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for linux message handler